Branch for update SCR Config default setup value #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammoody
reviewed
Mar 3, 2022
src/scr_conf.h
Outdated
Comment on lines
146
to
147
| /* #define SCR_MPI_BUF_SIZE (1*1024*1024) */ | ||
| #define SCR_MPI_BUF_SIZE (128*1024) /* very strange that this lower number beats the upper one, but whatever ... */ | ||
| #define SCR_MPI_BUF_SIZE (1024*1024) /* very strange that this lower number beats the upper one, but whatever ... */ |
There was a problem hiding this comment.
Thanks @hbchen1984 . Since this number now matches the number that is commented out above, let's drop both of these comments -- the comment above and the comment at the end of this line.
There was a problem hiding this comment.
Sounds good. Thanks.
remove the original comment about SCR_MPI_BUF_SIZE
|
Thanks, @hbchen1984 ! Nice find, and great idea to look for these and test them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update scr_conf.h
Use new values for buffer size used on MPI and FILE IO
/* =========================================================================
/* buffer size to use for MPI send / recv operations /
#ifndef SCR_MPI_BUF_SIZE
/ #define SCR_MPI_BUF_SIZE (110241024) /
/ change from 128KB to 1MB /
#define SCR_MPI_BUF_SIZE (10241024) /* very strange that this lower number beats the upper one, but whatever ... */
#endif
/* buffer size to use for file I/O operations /
/ change from 1MB tp 32MB /
#ifndef SCR_FILE_BUF_SIZE
#define SCR_FILE_BUF_SIZE (10241024*32)
#endif