Flux cleanup #585
Merged
Flux cleanup #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the FLUX ResourceManager docstrings are a bit messy. Clean them up and make them PEP8 compliant.
Problem: the Flux ResourceManager subclass in unnecessarily complicated. Clean it up and simplify the logic for checking down nodes.
Problem: 'bare' try/excepts catch all manner of exceptions and sometimes hide the true source of error. Add better handling for importing and using flux.
Problem: the Flux JobLauncher subclass has some stray variables and unidiomatic Python code. Clean it up.
Problem: the Flux RemoteExec subclass has some duplicated and messy code. Clean it up.
jameshcorbett
force-pushed
the
flux-cleanup
branch
from
ab2e8ec
to
3b96faf
Compare
mcfadden8
reviewed
Jan 31, 2024
We should definitely get CI that tests this if we don't have it! |
Thanks @jameshcorbett. @gonsie, do you know whether our CI tests this? If not, we can at least write up an issue to get it covered at some point. |
mcfadden8
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some of the Flux code.