Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform about how to create the QR code using shell #15

Merged
merged 3 commits into from
Jul 4, 2019

Conversation

Kixunil
Copy link
Contributor

@Kixunil Kixunil commented Jun 11, 2019

People might want to avoid adding another dependencies and compiling stuff for such simple task. The URL can be easily created using shell, so dependencies aren't even needed. This change helps people to use command line, so they don't have to invent it themselves.

People might want to avoid adding another dependencies and compiling stuff for such simple task. The URL can be easily created using shell, so dependencies aren't even needed. This change helps people to use command line, so they don't have to invent it themselves.
@ottosuess
Copy link
Member

is this command missing an echo '?

also instead of using xdg-open it could be cool to just use qrencode -t UTF8 to make it work on mac OS as well.

@Kixunil
Copy link
Contributor Author

Kixunil commented Jun 12, 2019

Ah, yeah, it is. Idon't have an experience with -t UTF8.

@ottosuess
Copy link
Member

cool 🙌

but i guess most of our users are either on a mac or using ssh to connect to a remote server.
so i don't want to merge xdg-open to avoid confusion. rather use qrencode -t UTF8 to print the qr code to the terminal or don't use xdg-open and just generate the image.

@michaelWuensch
Copy link

Please note that your command line does not give the same results as lndconnect.
Yor tls and macaroon are encode in Base64 while lndconnect encodes them in Base64Url

URL version of base64 encoding should be used instead, therefore appropriate conversion is applied in the command. Further, `xdg-open` isn't cross-platform, so it was removed.
@Kixunil
Copy link
Contributor Author

Kixunil commented Jun 16, 2019

@ottosuess OK, I've removed xdg-open completely, because as I found out -t UTF8 is completely impractical for such huge QR codes. (Changing spec to use fingerprint instead of whole TLS certificate might help.)

@michaelWuensch thanks for finding out! I managed to fix the encoding. I still can't connect, but at least I moved closer. :)

@ottosuess
Copy link
Member

lgtm 🙌

@ottosuess ottosuess merged commit 82d7103 into LN-Zap:master Jul 4, 2019
@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 24, 2019

If anyone is wondering, I managed to connect successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants