Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Store fonts locally to remove outbound web requests #2984

Closed
JimmyMow opened this issue Oct 12, 2019 · 4 comments
Closed

Store fonts locally to remove outbound web requests #2984

JimmyMow opened this issue Oct 12, 2019 · 4 comments
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@JimmyMow
Copy link
Member

We should download/buy the fonts we use so we aren't making web requests to fetch them. Improves privacy and likely some small performance enhancements.

https://twitter.com/nvk/status/1182671014909698048

@JimmyMow JimmyMow changed the title Store fonts locally to remove outbound calls Store fonts locally to remove outbound web requests Oct 12, 2019
@JimmyMow JimmyMow added the type: enhancement New feature or request label Oct 12, 2019
@bolatovumar
Copy link
Contributor

I have a commit that does this but I couldn't get font file import path to not be relative. I know we try not to use relative urls but my ability to configure webpack is not good enough to get this to work.

See commit here: bolatovumar@327e61e

@korhaliv
Copy link
Member

@bolatovumar try @zap/fonts

@bolatovumar
Copy link
Contributor

@korhaliv will attempt this

bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Oct 18, 2019
bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Oct 18, 2019
bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Oct 18, 2019
@mrfelton mrfelton added this to the v0.5.4-beta milestone Oct 18, 2019
@mrfelton
Copy link
Member

Closed via #3018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants