Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Transaction error modal dialog positioning of off-center #3183

Closed
mrfelton opened this issue Nov 14, 2019 · 0 comments · Fixed by #3188
Closed

Transaction error modal dialog positioning of off-center #3183

mrfelton opened this issue Nov 14, 2019 · 0 comments · Fixed by #3188
Labels
type: bug 🐛 Something isn't working
Milestone
v0.6.0-beta

Comments

@mrfelton
Copy link
Member

Description

Transaction error modal dialog positioning of off-center

image

Expected Behavior

Should be centered on the page

Actual Behavior

It's not centered

Possible Fix

Add static positioning, simmilar to what we do in the onboarding dialogs

Steps to Reproduce

Try to pay an invoice to yourself or one that has already expired of been paid, then click on the click here to see details link in the activity list entry

Context

Activity list
@mrfelton mrfelton added the type: bug 🐛 Something isn't working label Nov 14, 2019
@mrfelton mrfelton added this to the v0.6.0-beta milestone Nov 14, 2019
bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Nov 15, 2019
@bolatovumar
fix(ui): center failed payment error modal dialog
b08353c 
fix LN-Zap#3183
@bolatovumar bolatovumar mentioned this issue Nov 15, 2019
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.6.0-beta
Development

Successfully merging a pull request may close this issue.

fix(ui): center failed payment error modal dialog bolatovumar/zap-desktop
1 participant
@mrfelton