This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
feat: add ability to sign and verify messages #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korhaliv
added
type: enhancement
mrfelton
suggested changes
Aug 6, 2019
renderer/components/Profile/ProfilePaneSignMessage/ProfilePaneSignMessage.js
Outdated
Show resolved
Hide resolved
renderer/components/Profile/ProfilePaneVerifyMessage/ProfilePaneVerifyMessage.js
Outdated
Show resolved
Hide resolved
renderer/components/Profile/ProfilePaneSignMessage/ProfilePaneSignMessage.js
Outdated
Show resolved
Hide resolved
korhaliv
force-pushed
the
feat/sign-verify-message
branch
from
b47dc77 to
318dac1
Compare
|
@mrfelton updated |
korhaliv
force-pushed
the
feat/sign-verify-message
branch
from
318dac1 to
d392b87
Compare
mrfelton
suggested changes
Aug 7, 2019
renderer/components/Profile/ProfilePaneVerifyMessage/messages.js
Outdated
Show resolved
Hide resolved
korhaliv
force-pushed
the
feat/sign-verify-message
branch
from
d392b87 to
d66aed0
Compare
mrfelton
suggested changes
Aug 7, 2019
renderer/components/Profile/ProfilePaneSignMessage/ProfilePaneSignMessage.js
Outdated
Show resolved
Hide resolved
korhaliv
force-pushed
the
feat/sign-verify-message
branch
from
d66aed0 to
1c4ead1
Compare
mrfelton
approved these changes
Aug 7, 2019
Closed
|
Hi, is Sign Message also included in the iOS app and going to be available in App Store? |
|
@alevchuk this is the desktop app repo. Feel free to ask here (iOS repo): https://github.com/LN-Zap/zap-iOS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Resolves #2023
Also adds the ability to verify messages
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes:
New feature
Checklist: