This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Show number of confs for incoming onchain txs in activity list #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korhaliv
force-pushed
the
feat/unconf-conf-tx
branch
2 times, most recently
from
16171d5 to
db75ced
Compare
mrfelton
approved these changes
Aug 26, 2019
JimmyMow
suggested changes
Aug 29, 2019
mrfelton
added
type: enhancement
mrfelton
added
the
status: needs rebase
mrfelton
changed the title
|
When discussing with Namson and Ole, we all feel that showing the number of confirmations is an unnecessary addition to the UI, as it is always one click away in the detail modal. I do like the idea of being able to visually see what transactions are unconfirmed, but I think that is as far as this PR should go personally. What are your thoughts there? |
mrfelton
added a commit
to mrfelton/zap-desktop
that referenced
this pull request
Nov 6, 2019
6 tasks
mrfelton
added a commit
to mrfelton/zap-desktop
that referenced
this pull request
Nov 6, 2019
mrfelton
added a commit
to mrfelton/zap-desktop
that referenced
this pull request
Nov 6, 2019
mrfelton
added a commit
to mrfelton/zap-desktop
that referenced
this pull request
Nov 6, 2019
mrfelton
added a commit
to mrfelton/zap-desktop
that referenced
this pull request
Nov 6, 2019
mrfelton
added a commit
to mrfelton/zap-desktop
that referenced
this pull request
Nov 6, 2019
mrfelton
added a commit
to mrfelton/zap-desktop
that referenced
this pull request
Nov 6, 2019
korhaliv
force-pushed
the
feat/unconf-conf-tx
branch
from
db75ced to
ea0b045
Compare
korhaliv
removed
status: needs design
korhaliv
force-pushed
the
feat/unconf-conf-tx
branch
2 times, most recently
from
8f96fb8 to
d82f3ab
Compare
korhaliv
force-pushed
the
feat/unconf-conf-tx
branch
from
d82f3ab to
b8867b9
Compare
mrfelton
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Resoles #1685
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes:
Enhancement/feature
Checklist: