Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

chore: allow overriding state props in sb components #2844

Merged
merged 1 commit into from
Sep 3, 2019
Merged

chore: allow overriding state props in sb components #2844

merged 1 commit into from
Sep 3, 2019

Conversation

korhaliv
Copy link
Member

@korhaliv korhaliv commented Sep 3, 2019

Description:

This PR monkey patches react-redux connect to use defaultMergeProps that prioritizes ownProps over stateProps

Motivation and Context:

Simplify sb testing by allowing to mock redux actions

How Has This Been Tested?

yarn storybook

Types of changes:

Devops

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@korhaliv korhaliv added the scope: devops issues that affect devops label Sep 3, 2019
@korhaliv korhaliv added this to the v0.6.0-beta milestone Sep 3, 2019
@korhaliv korhaliv requested a review from mrfelton September 3, 2019 20:30
@korhaliv korhaliv self-assigned this Sep 3, 2019
@korhaliv korhaliv force-pushed the chore/patch-redux-connect branch from 1636135 to f4e0941 Compare September 3, 2019 20:35
@coveralls
Copy link

coveralls commented Sep 3, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 22.733% when pulling f4e0941 on korhaliv:chore/patch-redux-connect into 242b2bd on LN-Zap:next.

mrfelton
mrfelton approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@mrfelton mrfelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK f4e0941

@mrfelton mrfelton merged commit bdeac07 into LN-Zap:next Sep 3, 2019
@korhaliv korhaliv deleted the chore/patch-redux-connect branch September 5, 2019 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrfelton mrfelton mrfelton approved these changes

Assignees

@korhaliv korhaliv

Labels
scope: devops issues that affect devops
Projects
None yet
Milestone
v0.6.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@korhaliv @coveralls @mrfelton