This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 216
feat(app): basic password authentication #2860
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelton
force-pushed
the
feat/password
branch
from
September 9, 2019 14:08
273eb14
to
2ad04e8
Compare
mrfelton
added
scope: security
issues that are security related
type: enhancement
New feature or request
labels
Sep 9, 2019
mrfelton
changed the title
[WIP] feat(app): basic password authentication
feat(app): basic password authentication
Sep 9, 2019
mrfelton
force-pushed
the
feat/password
branch
from
September 9, 2019 14:29
2ad04e8
to
02179eb
Compare
korhaliv
suggested changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback
mrfelton
force-pushed
the
feat/password
branch
from
September 23, 2019 13:17
02179eb
to
fc31453
Compare
korhaliv
suggested changes
Sep 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
Updated |
mrfelton
force-pushed
the
feat/password
branch
from
September 26, 2019 14:39
fc31453
to
ddabf58
Compare
korhaliv
added
the
status: needs rebase
Issue needs to be rebased on top of the main branch
label
Sep 26, 2019
6 tasks
Closing in favour of #2940 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
scope: security
issues that are security related
status: needs rebase
Issue needs to be rebased on top of the main branch
type: enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds basic password authentication for the app. The password is stored in plain text in the indexed database so it's not a strong protection, however it does provide a useful basic level of protection.
This is currently an opt-in feature that users can enable from the preferences page
Additional things we should consider:
Motivation and Context:
Fix #1387
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes:
Feature
Checklist: