Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix(wallet): present correct fee when no route #3155

Merged
merged 1 commit into from
Nov 11, 2019
Merged

fix(wallet): present correct fee when no route #3155

merged 1 commit into from
Nov 11, 2019

Conversation

mrfelton
Copy link
Member

@mrfelton mrfelton commented Nov 9, 2019

Description:

Ensure fee rate is displayed as unknown if no routes are found.

Motivation and Context:

Fix #3154

How Has This Been Tested?

Manually

Types of changes:

Bug fix

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added type: bug 🐛 Something isn't working scope: wallet issues with the wallet interface labels Nov 9, 2019
@mrfelton mrfelton added this to the v0.6.0-beta milestone Nov 9, 2019
@mrfelton mrfelton requested a review from korhaliv November 9, 2019 09:21
@mrfelton mrfelton self-assigned this Nov 9, 2019
@coveralls
Copy link

coveralls commented Nov 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 22.735% when pulling 8b0a351 on mrfelton:fix/no-fee into ff4e7ba on LN-Zap:master.

korhaliv
korhaliv previously requested changes Nov 9, 2019
View reviewed changes
Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Q

renderer/components/Pay/PaySummaryLightning.js Outdated Show resolved Hide resolved
renderer/reducers/pay.js Show resolved Hide resolved
@mrfelton
fix(wallet): present correct fee when no route
8b0a351 
Ensure fee rate is displayed as `unknown` if no routes are found.

Fix LN-Zap#3154
@mrfelton mrfelton requested a review from korhaliv November 9, 2019 20:35
@mrfelton mrfelton dismissed korhaliv’s stale review November 9, 2019 20:39

Addressed concerns

korhaliv
korhaliv approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 8b0a351

@mrfelton mrfelton merged commit c327602 into LN-Zap:master Nov 11, 2019
@mrfelton mrfelton deleted the fix/no-fee branch November 11, 2019 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@korhaliv korhaliv korhaliv approved these changes

Assignees

@mrfelton mrfelton

Labels
scope: wallet issues with the wallet interface type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.6.0-beta
Development

Successfully merging this pull request may close these issues.

Fee rate displayed as less than 1 satoshi when route and fee is actually unknown
3 participants
@mrfelton @coveralls @korhaliv