This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
build(flow): include node_modules in flow config #702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
We're missing flow type definitions for grpc. This is due to the fact that it is installed in
app/node_modules
and notnode_modules
Proposed Solution
Currently, in our
.flowconfig
file we specifically excludenode_modules
andapp/node_modules
. I believe that this is left over fromelectron-react-boilerplate
and it isn't needed.See facebook/flow#869 for some context about why
node_modules
shouldn't really be excluded.This PR adds
node_modules
andapp/node_modules
back into the flow type processing, which as well as fixing the above issue, also makes flow generally more useful as it will provide type hints for many more packages.