[Syosetu] Extract all web novel chapters listed in multiple pages #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacktheripper19
commented
Nov 29, 2024
jacktheripper19
commented
- The previous version was only parsing pages from the first main page.
- Some web novels can have many chapters listed in multiple pages, so they need to be listed on the app as well.
- I could not find an API for listing all chapters from a single call.
- This version will go to the last page to get the total number of chapters, then use the pattern of increasing the id number to iterate over all of them.
- Therefore it is slightly slow for loading two pages. It is still better than loading every page.
…ction - Parse novel status based on announcement. - Fix title not showing in the app. - Extract author name. - Improve release date extraction.
nyagami
reviewed
Nov 30, 2024
|
you should increase plugin version to notify new update to app (1.1.1) |
nyagami
approved these changes
Dec 1, 2024
nyagami
approved these changes
Dec 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.