Feature/chapter drawer

[CD-Z]

Information

This feature adds a drawer to the ReaderScreen which allows the user to see chapters and switch between them.

Additional package

• @react-navigation/drawer: "^6.0.1"

Problem

• If Render in HTML is activated, it is not possible to swipe the drawer open, because it doesn't register the swipe on the WebView.
  • Through changing the padding-left of the html body to a marginLeft of the WebView, it creates a small part where the drawer can be opened.

[SkillGG]

Wouldn't activating it by clicking a button be better? Because swiping is reserved for changing to next/previous chapter?

[CD-Z]

I thought the same, however the swipe gesture of the drawer superimpose over the one of the gesture recognizer and since it is limited to 60 on the left side it is easy to differentiate between the both of them.
The only problem is with the WebView since there is only a very small space where you can drag the drawer.

As for why I didn't use a button. I simply haven't found a place I find suitable and think it is more intuitive to swipe.

[SkillGG]

What about there:

[SkillGG]

Also adding a hard margin to WebView to allow for that swiping gesture makes the text off-center

Edit:
And sorry for being s bit nitpicky, but why a drawer?
Wouldn't a pop-up (like Tachiyomi one) be better? No issues with swiping at all and yes, you wouldn't be able to get the pop-up to show with a gesture but with a button, but it'd way simpler to implement but still have exactly the same functionality.
But maybe I think that just because I use Android Gestures so I have problem with any app overwriting them for drawers.
Maybe if you added a FAB that you could catch to open a drawer instead of doing a "anywhere on the left side just swipe" type of thing...

[CD-Z]

No problem. I welcome other opinions and I can't complain to you since I myself am also very nitpicky sometimes. I changed it as yous suggested and left the button as a permanent in there. The setting to enable the drawer now works as a swipeGesture enabler. I really like to be able to swipe to open the drawer, so I really want to let it in there.
In my opinion a FAB isn't really suitable, since it is to distracting while reading.

[CD-Z]

In the latest commits I added a ts file, which helps to pass props for navigation.navigate.
I would appreciate feedback if this makes sense or is just unnecessary. Also is the placement of the file good?

[rajarsheechatterjee]

In the latest commits I added a ts file, which helps to pass props for navigation.navigate. I would appreciate feedback if this makes sense or is just unnecessary. Also is the placement of the file good?

Yeah, it makes sense to define it at a single place than creating the params object everywhere.