This repository has been archived by the owner on Jan 24, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Assignment #27
Open
AmaranthineCodices
wants to merge
4
commits into
LPGhatguy:master
Choose a base branch
from
AmaranthineCodices:assignment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Assignment #27
AmaranthineCodices
wants to merge
4
commits into
LPGhatguy:master
from
AmaranthineCodices:assignment
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wonder if it's time to push the concept of an lvalue into the parser's lingo! |
Closed
Kampfkarren
reviewed
Mar 9, 2019
match state.peek() { | ||
Some(&Token { kind: TokenKind::Symbol(Symbol::Dot), .. }) => { | ||
let (state, name) = ParseIdentifier.parse(state.advance(1))?; | ||
println!("parsed dot index {:?}", name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug line
Kampfkarren
reviewed
Mar 9, 2019
Some(&Token { kind: TokenKind::Symbol(Symbol::LeftBracket), .. }) => { | ||
let (state, expression) = ParseExpression.parse(state.advance(1))?; | ||
let (state, _) = ParseSymbol(Symbol::RightBracket).parse(state)?; | ||
println!("parsed bracketed index {:?}", expression); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short: Parsing assignments. All of them (I think). This is disturbingly complex, because Lua allows things like this:
The intermediate stuff for this is actually very helpful; it'll allow us to parse function calls very easily.