Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a short check to see if mean magnitude is passed into variable signal #256

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

Henry-Best-01
Copy link
Contributor

Include a small check if a mean magnitude kwarg is passed to the lamppost reprocessed signal

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (ac07439) to head (149032d).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   97.89%   97.74%   -0.15%     
==========================================
  Files          70       70              
  Lines        4652     4666      +14     
==========================================
+ Hits         4554     4561       +7     
- Misses         98      105       +7     
Flag Coverage Δ
97.74% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/SourceVariability/accretion_disk_reprocessing.py 100.00% <100.00%> (ø)
slsim/Sources/SourceVariability/variability.py 100.00% <100.00%> (ø)
slsim/Sources/agn.py 100.00% <100.00%> (ø)
slsim/Sources/source.py 98.95% <100.00%> (ø)

... and 3 files with indirect coverage changes

@Henry-Best-01
Copy link
Contributor Author

@nkhadka21, do you have any advice on how I can get codecov/project to succeed?

Copy link
Collaborator

@nkhadka21 nkhadka21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Henry-Best-01, thank you very much for this PR! It looks good to me.

@nkhadka21 nkhadka21 merged commit d687c43 into LSST-strong-lensing:main Sep 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants