You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IMO, create is not a very descriptive name. Especially when used with from firecrown.parameters import create, having code in Updatables that looks like
def __init__(self):
...
self.f_bar = create()
is not very self-explanatory, especially considering all the complexity that happens behind the scenes.
Calling it something like register_new_parameter might be helpful, since I imagine many users are not used to kind of __setattr__ magic that's being used here.
The text was updated successfully, but these errors were encountered:
IMO,
create
is not a very descriptive name. Especially when used withfrom firecrown.parameters import create
, having code inUpdatables
that looks likeis not very self-explanatory, especially considering all the complexity that happens behind the scenes.
Calling it something like
register_new_parameter
might be helpful, since I imagine many users are not used to kind of__setattr__
magic that's being used here.The text was updated successfully, but these errors were encountered: