Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed create to register_new_updatable_parameter. #334

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Renamed create to register_new_updatable_parameter. #334

merged 1 commit into from
Oct 20, 2023

Conversation

vitenti
Copy link
Collaborator

@vitenti vitenti commented Oct 20, 2023

No description provided.

@vitenti vitenti linked an issue Oct 20, 2023 that may be closed by this pull request
Give firecrown.parameters.create a more descriptive name #333
Closed
@vitenti
Copy link
Collaborator Author

vitenti commented Oct 20, 2023

@tilmantroester tell me if that's what you had in mind. I kept the old create function as a deprecated function to be removed in the next major release.

marcpaterno
marcpaterno approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@marcpaterno marcpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new name is a clear improvement.

@tilmantroester
Copy link
Contributor

LGTM!

@vitenti vitenti merged commit f849d18 into master Oct 20, 2023
8 checks passed
@vitenti vitenti deleted the 333-parameters-create-rename branch October 20, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilmantroester tilmantroester tilmantroester approved these changes

@marcpaterno marcpaterno marcpaterno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give firecrown.parameters.create a more descriptive name
3 participants
@vitenti @tilmantroester @marcpaterno