Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading likelihoods from python packages #340

Closed
tilmantroester opened this issue Oct 26, 2023 · 0 comments · Fixed by #341
Closed

Support loading likelihoods from python packages #340

tilmantroester opened this issue Oct 26, 2023 · 0 comments · Fixed by #341
Assignees

Comments

@tilmantroester
Copy link
Contributor

It would be useful to support loading the build_likelihood factory from python packages, rather than file names.
For example, to support usage like firecrownIni: desc_baryon_challenge.likelihoods.firecrown_likelihood.
Or maybe better more explicitly: firecrown_likelihood_factory: desc_baryon_challenge.likelihoods.firecrown_likelihood.build_likelihood

With the option to pass build_parameters, this should allow quite generic likelihood factories that can be shipped centrally in a python package.

A specific use case is the baryon challenge: https://github.com/LSSTDESC/baryon-challenge/blob/main/src/desc_baryon_challenge/likelihoods/firecrown_likelihood.py

@vitenti vitenti self-assigned this Oct 30, 2023
@vitenti vitenti linked a pull request Oct 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants