Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New load_likelihood_from_module #341

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

vitenti
Copy link
Collaborator

@vitenti vitenti commented Oct 30, 2023

This PR introduces a new loading method to the system, which permits the direct loading of likelihoods from individual modules. This enables multiple likelihoods to be organized within a single Python package.

@vitenti vitenti linked an issue Oct 30, 2023 that may be closed by this pull request
@vitenti
Copy link
Collaborator Author

vitenti commented Oct 30, 2023

@tilmantroester does this PR address #340 ?

@tilmantroester
Copy link
Contributor

Yes, I think so.

Being able to specify the entry point (i.e., a function that's not necessarily named build_likelihood) would be a useful feature, so that different likelihood factories can be defined in the same file/module. But that's probably best done in a separate PR.

@marcpaterno marcpaterno merged commit 829ce76 into master Oct 30, 2023
8 checks passed
@marcpaterno marcpaterno deleted the 340-load-likelihoods-from-module branch October 30, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support loading likelihoods from python packages
3 participants