Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved numcosmo connector #369

Merged
merged 22 commits into from
Feb 6, 2024
Merged

Conversation

vitenti
Copy link
Collaborator

@vitenti vitenti commented Feb 3, 2024

New connector using improved NumCosmo serialization to avoid pickle and base64.
Using NumCosmo app instead of extra scripts.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e95c803) 95.4% compared to head (314928b) 95.4%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #369     +/-   ##
========================================
- Coverage    95.4%   95.4%   -0.1%     
========================================
  Files          36      35      -1     
  Lines        2556    2569     +13     
========================================
+ Hits         2439    2451     +12     
- Misses        117     118      +1     
Files Coverage Δ
firecrown/connector/numcosmo/numcosmo.py 99.7% <100.0%> (-0.3%) ⬇️
firecrown/likelihood/likelihood.py 99.2% <100.0%> (+0.1%) ⬆️

@marcpaterno marcpaterno merged commit 0c4ae2d into master Feb 6, 2024
7 of 8 checks passed
@marcpaterno marcpaterno deleted the improved_numcosmo_connector branch February 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants