Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Validator base class, fix hidden type error #378

Conversation

marcpaterno
Copy link
Collaborator

This will close issue #377 . It also fixes a type error that was made manifest when the tighter type signatures were put into place.

@marcpaterno marcpaterno linked an issue Feb 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (481a6bc) 96.2% compared to head (8cee81e) 96.2%.
Report is 1 commits behind head on master.

❗ Current head 8cee81e differs from pull request most recent head 8070355. Consider uploading reports for the commit 8070355 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #378   +/-   ##
======================================
  Coverage    96.2%   96.2%           
======================================
  Files          35      35           
  Lines        2569    2573    +4     
======================================
+ Hits         2472    2476    +4     
  Misses         97      97           
Files Coverage Δ
firecrown/connector/mapping.py 100.0% <100.0%> (ø)
firecrown/descriptors.py 100.0% <100.0%> (ø)

@vitenti vitenti merged commit be43590 into master Feb 15, 2024
8 checks passed
@vitenti vitenti deleted the 377-the-abstract-base-class-validator-makes-type-checking-awkward branch February 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The abstract base class Validator makes type checking awkward
3 participants