Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 413 #415

Merged
merged 3 commits into from
May 2, 2024
Merged

Bug 413 #415

merged 3 commits into from
May 2, 2024

Conversation

marcpaterno
Copy link
Collaborator

This adds a test that demonstrates the bug, and then fixes the bug.

@marcpaterno marcpaterno requested a review from vitenti May 2, 2024 19:11
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (two_point_refactor@18bf57b). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             two_point_refactor    #415   +/-   ##
====================================================
  Coverage                      ?   93.0%           
====================================================
  Files                         ?      35           
  Lines                         ?    2663           
  Branches                      ?       0           
====================================================
  Hits                          ?    2478           
  Misses                        ?     185           
  Partials                      ?       0           
Files Coverage Δ
...own/likelihood/gauss_family/statistic/two_point.py 58.3% <100.0%> (ø)
firecrown/version.py 100.0% <100.0%> (ø)

@marcpaterno marcpaterno merged commit d61a741 into two_point_refactor May 2, 2024
10 checks passed
@marcpaterno marcpaterno deleted the bug-413 branch May 2, 2024 20:36
@marcpaterno marcpaterno restored the bug-413 branch May 2, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants