Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend astropy's FlatLambdaCDM #636

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Extend astropy's FlatLambdaCDM #636

merged 2 commits into from
Jun 18, 2024

Conversation

yymao
Copy link
Member

@yymao yymao commented Jun 18, 2024

This PR introduces a new subclass from astropy's FlatLambdaCDM. The new subclass is identical to FlatLambdaCDM except that it can accept additional attributes, maintaining the original behavior.

Fix #635

@yymao yymao requested a review from JoanneBogart June 18, 2024 04:00
JoanneBogart
JoanneBogart approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@JoanneBogart JoanneBogart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Yao! This looks fine and I confirmed it does fix the problem I saw.
Perhaps the CI should be updated to exercise Python 3.11.
I see there is some apparently unrelated problem causing the 3.10 build to fail.

@yymao
Copy link
Member Author

yymao commented Jun 18, 2024

Thanks @JoanneBogart. Going to ignore the CI for now. Need to fix that indeed..

@yymao yymao merged commit 1fe7bcd into master Jun 18, 2024
0 of 3 checks passed
@yymao yymao deleted the issues/635/Incompatibility-with-astropy-610 branch June 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanneBogart JoanneBogart JoanneBogart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatibility with astropy 6.1.0
2 participants
@yymao @JoanneBogart