Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to select config source via environment variable #639

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

JoanneBogart
Copy link
Contributor

Allow user to specify config source via environment variable GCR_CONFIG_SOURCE (acceptable values are dataregistry or files) so that they don't have to modify code to make the choice.
Also use value of GCR_DR_SCHEMA if set to specify dataregistry schema to use; otherwise default to "production".

@JoanneBogart JoanneBogart requested a review from yymao September 13, 2024 23:31
Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@JoanneBogart JoanneBogart merged commit f339e3a into master Sep 16, 2024
3 checks passed
@JoanneBogart JoanneBogart deleted the u/jrbogart/integrate_dataregistry2 branch September 16, 2024 01:36
@JoanneBogart
Copy link
Contributor Author

Thank you, @yymao, for attending to this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants