-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add examle PyPI upload example #256
Conversation
@heather999 the PyPI API token was created and the secret has been set with the name |
Great! Right now, to trigger this workflow, we need a new release tag on snmachine - and that will cause the workflow to start up. Right now, the workflow is only uploading to testpypi just so we can see this is working as expected. |
Oh, I had setup the secret and the API on PyPI and not on TestPyPI. Will that generate any issue? |
ah yes! :) sorry Ok let me see if I can do a quick test by forking this repo and running this to upload to testpypi. That would make me feel more confident before asking this be merged to master |
Hi @Catarina-Alves I was able to partially test and fix a small typo. I can't upload to testpypi since I'm not a maintainer on snmachine and that is fine. So I think to move ahead, we can do the following:
|
@heather999, the new API token and secret are created. I also updated the secret name in the workflow to TESTPYPI_API_TOKEN. |
@Catarina-Alves that looks perfect. Yes, the next step is to merge to main and create a new Release tag on snmachine. Then we should see a build start up under the "Actions": https://github.com/LSSTDESC/snmachine/actions |
@heather999, the new release was successfully uploaded to TestPyPI: https://test.pypi.org/manage/project/snmachine/release/2.0.0.dev0/ |
Thank you @Catarina-Alves I can confirm I was able to install this version from testpypi I just want to run through a couple of your notebooks and see that they generally work. I'll do that in the morning! |
@heather999 I just wanted to know if you found any issues, or if |
IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): #255
Type of change
Please delete options that are not relevant.
What changes were proposed in this pull request?
Adding new GH Action to automate upload to PyPI for new releases
How was this patch tested?
Has not been tested directly with snmachine yet. Once a new GitHub secret is added, we can see how this workflow functions using the testPyPI to start
Final Checklist:
dev
branch ofsnmachine
at the time of this PR