fix(core) callback wrapper memory leak

When using the CHM closure registry, the Java-side wrapper object was never removed from the map.
LWJGL · Sep 30, 2023 · 98ef5e7 · 98ef5e7
1 parent e698513
commit 98ef5e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/doc/notes/3.3.4.md b/doc/notes/3.3.4.md
@@ -10,6 +10,7 @@ This build includes the following changes:
 
 #### Fixes
 
+- Core: Fixed callback wrapper memory leak with the CHM closure registry. (#927)
 - tinyfd: The `aDefaultPath` parameter of `tinyfd_selectFolderDialog` is now nullable. (#922)
 
 #### Breaking Changes
diff --git a/modules/lwjgl/core/src/main/java/org/lwjgl/system/Callback.java b/modules/lwjgl/core/src/main/java/org/lwjgl/system/Callback.java
@@ -206,7 +206,7 @@ public static void free(long functionPointer) {
             MemoryManage.DebugAllocator.untrack(functionPointer);
         }
 
-        FFIClosure closure = CLOSURE_REGISTRY.get(functionPointer);
+        FFIClosure closure = CLOSURE_REGISTRY.remove(functionPointer);
 
         DeleteGlobalRef(closure.user_data());
         ffi_closure_free(closure);
@@ -234,4 +234,4 @@ public String toString() {
         return String.format("%s pointer [0x%X]", getClass().getSimpleName(), address);
     }
 
-}
+}