GLFW Boolean return type

[ShadowLordAlpha]

Both OpenAL and OpenGL have Boolean return methods that are used in place of their *_TRUE and *_FALSE return values. GLFW also does this but does not make a special type for the Boolean value and instead treats it as an int (OpenGL and OpenAL treat it as a byte if I remember correctly but only give it the true or false value) so it should be possible to make it so that certain GLFW functions that are documented Boolean returns actually return a Boolean java type. Its not really required as its easy enough to just do glfwInit() != GLFW_TRUE but it would be nice to have.

[Spasi]

Technically it's possible (and easy). LWJGL normally does this only when the native API has a dedicated boolean type.

Is anyone against such a change? It will affect the following functions:

• glfwInit
• glfwWindowShouldClose
• glfwSetWindowShouldClose
• glfwJoystickPresent
• glfwExtensionSupported
• glfwVulkanSupported
• glfwGetPhysicalDevicePresentationSupport

[quazi-irfan]

In GLFW we do,
if (!glfwInit())
But in LWJGL 3 we write the same things as,
if ( glfwInit() != GLFW_TRUE )

@Spasi Why GLFW_TRUE was chosen instead of native Java boolean?

[Spasi]

@iamcreasy I mentioned this, int is used because that's what the native API uses. C code can do:

if ( !glfwInit() )

because C supports numeric values in conditions (they are automatically compared against 0).

[arisona]

That would be great! In addition, there are a few callbacks that have boolean type arguments, such as the iconify callback or the cursor enter callback. Could this be done there as well for consistency?

[Spasi]

@arisona Thanks for the reminder, those callbacks have changed too.