Add missing input for CopyJsp and missing onlyIf config for WriteDependenciesFile
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
approved these changes
Jul 18, 2024
Comment on lines
44
to
50
| task.externalDependencies.set(project.extensions.findByType(ModuleExtension.class).getExternalDependencies()) | ||
| task.onlyIf { | ||
| return !task.externalDependencies.get().isEmpty() | ||
| } | ||
| } catch (UnknownDomainObjectException ignore) { | ||
|
|
||
| } |
There was a problem hiding this comment.
Would an UnknownDomainObjectException cause this task to run when it shouldn't since task.onlyIf {...} won't be reached?
Should the onlyIf just be baked into WriteDependenciesFile, similar to InstallRPackage?
There was a problem hiding this comment.
Technically, that's two questions. 😄, but they are both good questions, so I'll let it slide.
Effectively, it won't happen anymore that the exception is thrown since the configuration is created more broadly, but still a good idea to check. I had assumed Gradle wouldn't like the onlyIf inside the class, but that's cleaner, so I'll try it.
There was a problem hiding this comment.
There is no escape from off-by-one errors 😰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The previous PR failed to configure the
CopyJsptask properly so changes to individualJspfiles were not being picked up (not sure this change to requiring the use of FileSystem injection is altogether a good thing...).The previous PR also failed to prevent the
WriteDependenciesFiletask from running when a module, such as a file-based module, has no dependencies to write about.Related Pull Requests
Changes
InputDirectoryforCopyJsptaskonlyIfconfig forWriteDependenciesFiletask