-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package distribution as UMD #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove rollup - no longer build ES module - switch to using "index" rather than "labkey"
labkey-nicka
force-pushed
the
fb_umd_no_rollup
branch
from
March 30, 2020 00:19
87258f4
to
3282e3e
Compare
cnathe
approved these changes
Mar 30, 2020
labkey-susanh
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a copy-paste update suggestion.
webpack.config.js
Outdated
|
||
optimization: { | ||
// don't minimize the code from components, module/app usages will be doing that if they want to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// don't minimize the code from components, module/app usages will be doing that if they want to | |
// don't minimize; module/app usages will be doing that if they want to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This PR changes package distribution for
@labkey/api
to use UMD. The package can now fully be built with webpack so I've removed rollup and it's configuration.Changes
@labkey/components
.jest
configuration inpackage.json
.loadDOMContext().$
instead. Added test.