Changes to Short URL admin page #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
requested changes
Oct 9, 2023
- Display ShortURL table only if container is root and user has AdminOperationsPermission - Enable standard update and delete
|
FB mirrored in the LK repo https://github.com/LabKey/platform/tree/23.7_fb_shorturl-admin I also queued a run for the Panorama Public tests. I know that workflow uses short URLs but it may not go through the admin page. |
labkey-jeckels
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
panoramaweb.org has over 1K short URLs. The admin page renders all existing short URLs in a JSP page. We would like replace this with a LabKey grid to enable filtering and sorting. This should also speed up the time taken to fully load the page on panoramaweb.org
Changes
Replaced the JSP page that lists all the short URLs with a LabKey grid. Added a ShortUrlTableInfo class. The shorturl table is not exposed through the query schema browser.