Fix notebook data reference #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-susanh
approved these changes
Dec 18, 2024
| @@ -633,7 +633,8 @@ public String getDocumentId() | |||
| ExpDataClass dc = getDataClass(null); | |||
| if (dc != null) | |||
| dataClassName = dc.getName(); | |||
| return "data:" + new Path(getContainer().getId(), dataClassName, Integer.toString(getRowId())); | |||
| // why not just data:rowId? | |||
There was a problem hiding this comment.
good question. I'm not sure why the dataClassName is needed. We don't use it for materials, for example. Probably done to make the id more human-readable in some way, but we don't make any concessions to that in other places, so I would guess data:rowId would work just fine.
The last revision of this method had this comment:
// CONSIDER: use lsid so we can crack it later? Include dataClassId?
return "data:" + new Path(getContainer().getId(), Integer.toString(getRowId()));
But for materials, we don't even add the container id (certainly not needed for uniqueness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The documentId for dataclass data include the dataclass name. When the dataclass name contains special characters such as "/", the documentId cannot be parsed correctly.
SMProFolderExclusionTest.testExistingReferencesWithUpdatedExclusion
Related Pull Requests
Changes