Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.apache.commons:commons-compress to 1.24.0 #570

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Sep 19, 2023

Rationale

Fixing error: https://teamcity.labkey.org/test/529818193974818065?currentProjectId=LabKey_237Release_Internal_InternalSuites&expandTestHistoryChartSection=true

Related Pull Requests

  • N/A

Changes

  • Update org.apache.commons:commons-compress to 1.24.0

@labkey-adam
Copy link
Contributor

labkey-adam commented Sep 19, 2023

Tika does directly rely on Commons Compress and our current Tika version (and the most recent release) specifies 1.23.0. I suspect there will be no problem with 1.24.0, but the Tika link is still relevant.

For example: https://github.com/apache/tika/blob/2.8.0/tika-parent/pom.xml

@labkey-tchad
Copy link
Member Author

Tika does directly rely on Commons Compress and our current Tika version (and the most recent release) specifies 1.23.0. I suspect there will be no problem with 1.24.0, but the Tika link is still relevant.

For example: https://github.com/apache/tika/blob/2.8.0/tika-parent/pom.xml

Oh, thank you. I didn't see it in the gradle dependency tree because we have the tika libraries set to transitive = false

@labkey-adam
Copy link
Contributor

Tika does directly rely on Commons Compress and our current Tika version (and the most recent release) specifies 1.23.0. I suspect there will be no problem with 1.24.0, but the Tika link is still relevant.
For example: https://github.com/apache/tika/blob/2.8.0/tika-parent/pom.xml

Oh, thank you. I didn't see it in the gradle dependency tree because we have the tika libraries set to transitive = false

I believe that's because, left to its own devices, Tika brings in the entire world. We used to include it all (running Tika in its own class loader to prevent conflicts) but now we curate a list of parsers (therefore file formats) that we care about.

@labkey-ians
Copy link
Contributor

labkey-ians commented Sep 19, 2023

Looks like there is a new Tika version (2.9.0), but that would likely mean bumping a few other libraries that should also be sync'ed. Also, I'm not sure if it actually brings the new desired version or not, Maven Central's new search isn't cooperating with its dependency graph.

@labkey-adam
Copy link
Contributor

Looks like there is a new Tika version (2.9.0), but that would likely mean bumping a few other libraries that should also be sync'ed. Also, I'm not sure if it actually brings the new desired version or not, Maven Central's new search isn't cooperating with its dependency graph.

We should upgrade Tika, but no need to link it with this change

@labkey-tchad
Copy link
Member Author

Looks like there is a new Tika version (2.9.0), but that would likely mean bumping a few other libraries that should also be sync'ed. Also, I'm not sure if it actually brings the new desired version or not, Maven Central's new search isn't cooperating with its dependency graph.

Tika 2.9.0 doesn't update commons-compress: https://mvnrepository.com/artifact/org.apache.tika/tika-parsers/2.9.0

@labkey-ians
Copy link
Contributor

Thanks Trey that's what I was looking for. I should have also figured it out, given their respective release dates too.

@labkey-tchad labkey-tchad merged commit 375b8d1 into release23.7-SNAPSHOT Sep 19, 2023
1 check passed
@labkey-tchad labkey-tchad deleted the 23.7_fb_commonsCompressUpdate branch September 19, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants