Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Test Components for Customize Tool-Tips Testing #2080

Merged

Conversation

labkey-danield
Copy link
Contributor

@labkey-danield labkey-danield commented Oct 1, 2024

Rationale

Removed / Renamed references to grid, columns or GridColumns.
Converted to use the term 'fields', this was consistent with other method names.

Related Pull Requests

Changes

  • Changed CustomizeGridViewDialog to FieldSelectionDialog
  • Updated the reference to the UI component this wraps.
  • Changed column(s) to field(s).
  • Removed references to grid(s).
  • Added FieldSelectionDialog.canFieldBeRemoved
  • Added FieldSelectionDialog.repositionSelectedFields

Requested Changes from Closed PR

  • Changed CustomizeGridViewDialog.selectFieldFromSelectedFields to CustomizeGridViewDialog.highlightFieldInSelectedFields

Copy link

github-actions bot commented Oct 1, 2024

WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive.

@labkey-danield labkey-danield changed the title 24.10 fb customize tool tip automation Update Test Components for Customize Tool-Tips Testing Oct 1, 2024
@labkey-danield labkey-danield merged commit 6c6978f into release24.10-SNAPSHOT Oct 9, 2024
3 checks passed
@labkey-danield labkey-danield deleted the 24.10_fb_customizeToolTip_Automation branch October 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants