Update API key tests to use ApiKeyPanel and ApiKeyDialog #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relocate ApiKeyPanel and ApiKeyDialog
labkey-susanh
approved these changes
Oct 10, 2024
| getWrapper().shortWait().until(ExpectedConditions.invisibilityOf(elementCache().descriptionInput.getComponentElement())); | ||
| clearElementCache(); | ||
| getWrapper().shortWait().until(ExpectedConditions.visibilityOf(elementCache().inputField.getComponentElement())); | ||
| return this; |
There was a problem hiding this comment.
I would have thought using this might produce a stale element exception. If not, then so much the better.
There was a problem hiding this comment.
The body of the dialog does go stale (hence the clearElementCache) but the outer div of the dialog is stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Tests should use shared components when able.
ApiKeyPanelshould live intestAutomationsince it isn't specific to sample manager.Related Pull Requests
Changes
org.labkey.test.components.core