Test coverage for Issue 39496 #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-chrisj
requested review from
labkey-tchad and
labkey-danield
and removed request for
a team,
labkey-tchad and
labkey-danield
cnathe
reviewed
Oct 11, 2024
| // expect 3 rows in this assay, p2 and p3 should get mv indicators in the count column | ||
| Map<String, List<Integer>> expectedMVIndicators = new HashMap<>(); | ||
| expectedMVIndicators.put("Count", List.of(1, 2)); | ||
| checkMvIndicatorPresent(dataRegion, expectedMVIndicators); |
There was a problem hiding this comment.
this looks good and matches the approach we discussed!
looks like the other test cases in this file also have a call to checkDataregionData() that goes with the checkMvIndicatorPresent() call.
There was a problem hiding this comment.
I've added a check for dataRegion data to the test, thanks for the suggestion
labkey-tchad
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This adds regression coverage for Issue 39496, which verifies that missing values written to an assay via the
SaveBatchAPI are handled as expected.On a related note, this test sets up a simple way to verify whether or not missingValue indicators should be exported or not; Issue 37610 tracks this question and is a very stale issue; current behavior is to export empty values (not showing missing-value indicators as they appear in the dataregion) and in the years this issue has been around, nobody has asked for a fix. (so, this might be an opportune time to decide whether or not to expect missingValue indicators to be exported)
It also attempts to address the intermittent test failure in BiologicsSampleTimelineTest.testEditSampleDetailCausesTimelineEvent, which seems to be caused by a race condition in which the test looks for a select in
DetailTableEditbefore it is rendered, without waiting for it to appear.Related Pull Requests
n/a
Changes