Add a long report ETL for testing pipeline job cancellation #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Oct 12, 2024
| @@ -127,7 +128,7 @@ public TransformRow setEnabled(boolean enable) | |||
| // | |||
| // public TransformRow setVerboseLoggingEnabled(boolean enable) | |||
There was a problem hiding this comment.
Delete this commented out code?
| @@ -22,6 +22,7 @@ | |||
| import org.labkey.test.components.Component; | |||
There was a problem hiding this comment.
Probably we should wait for when we consolidate into premiumModules, but it seems like it would be nice to have this test code and the ETLtest module live into the same repo as dataintegration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In order to verify that cancelling a report job terminates the process, we need a long-running ETL.
Related Pull Requests
Changes
ETLScheduler