FilterSelectionDialog: handle non-removable fields #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-chrisj
approved these changes
Dec 12, 2024
|
|
||
| for(WebElement listItem : allItems) | ||
| for (WebElement listItem : allItems) |
There was a problem hiding this comment.
Occasionally this method will fail because not every item was removed-- one theory I have is that it might be due to how they slide up when the previous one is removed. It might be more reliable to iterate from the bottom up, if it's possible for the click to 'miss' if it happens when the target is moving
There was a problem hiding this comment.
I'm going to leave as-is since I'm not looking to triage intermittent failures with this work. What you are proposing seems reasonable.
labkey-nicka
force-pushed
the
fb_registry_changes
branch
from
d4becd7 to
64a43ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Update
FieldSelectionDialogtest component to handle removing all selected fields edge case where some fields are not actually removable.Related Pull Requests
Changes