-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation rules for input rasters #111
Add validation rules for input rasters #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with known database with problmes
Tested with known database with problems |
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Conflicts
Checklist
Description
Added the following rules in
RasterDataRules
enum:FORBID_NO_DATA
: Ensure no parts of the raster containNO_DATA
values;FORBID_ALL_ZEROES
: Ensure the raster does not consist entirely of zero values;FORBID_ALL_ONES
: Ensure the raster does not consist entirely of one values;FORBID_OUT_OF_RANGE
: Ensure the raster pixels must be within the specified valid range.Implemented a validation mechanism based on Chain of Responsibility pattern that checks each raster dataset against the above rules (
RasterMapValidator
);The validation is performed automatically as part of the model simulation configuration processing pipeline (
ModelConfiguration
), flagging any datasets that violate their respective rules for further investigation or correction;Configures use of GitHub Actions for CI to run related tests on each push and pull request.
Related Issue
Motivation and context
How has this been tested
Screenshots