Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DEM raster (GeoTIFF) from simulation configuration and model report #154

Conversation

soaressgabriel
Copy link
Collaborator

@soaressgabriel soaressgabriel commented Feb 23, 2024

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

Related Issue

Motivation and context

How has this been tested

  • The behavior and simulation results of the model must remain unchanged in relation to the current implementation:

    1. Set up a simulation enabling all simulation outputs (rasters and tables);
    2. Run the simulation;
    3. Verify that the specified rasters and tables files were created in the output directory.

Screenshots

  • N/A

@soaressgabriel soaressgabriel added the help wanted Extra attention is needed label Feb 23, 2024
@soaressgabriel soaressgabriel self-assigned this Feb 23, 2024
Copy link
Collaborator

@LINAMARIAOSORIO LINAMARIAOSORIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine!

@soaressgabriel soaressgabriel marked this pull request as ready for review February 26, 2024 17:12
@soaressgabriel soaressgabriel dismissed LINAMARIAOSORIO’s stale review February 26, 2024 17:34

The merge-base changed after approval.

@soaressgabriel soaressgabriel merged commit b6a6f33 into main Feb 26, 2024
4 checks passed
@soaressgabriel soaressgabriel deleted the 112-check-the-need-to-have-the-dem-raster-in-two-formats-pcraster-map-and-geotiff branch March 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the need to have the DEM raster in two formats (PCRaster Map and GeoTIFF)
2 participants