Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate RuntimeError exception handling and logging in file reading operations #98

Conversation

soaressgabriel
Copy link
Collaborator

Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

  • This pull request adds exception handling for RuntimeError during file reading operations in our distributed hydrological model project;
  • In addition, it introduces logging at these points and other key areas in the codebase;
  • The added logs will provide more context about the system's operation, assisting in the identification and resolution of any potential issues.

Related Issue

Motivation and Context

  • The motivation for these changes is twofold:
    • Firstly, to improve the system's robustness and user experience by preventing unexpected crashes due to file read issues. This is achieved by adding exception handling for RuntimeError;
    • Secondly, to aid in troubleshooting and provide users with more information about the system's operation through the addition of logging.

How Has This Been Tested

  • TBF

@soaressgabriel soaressgabriel added the high High priority label May 17, 2023
@soaressgabriel soaressgabriel self-assigned this May 17, 2023
@LINAMARIAOSORIO
Copy link
Collaborator

Tested using QGIS PLUGIN. Results approved

Copy link
Collaborator

@LINAMARIAOSORIO LINAMARIAOSORIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soaressgabriel soaressgabriel merged commit f12d1e7 into main May 17, 2023
@soaressgabriel soaressgabriel deleted the feature/97-incorporate-runtimeerror-exception-handling-in-file-reading-operations branch May 17, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate RuntimeError exception handling in file reading operations
2 participants