Video/media: add metadata to modals #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The metadata (and embed from before) are wired up for individual YouTube vids if you want to test it out: http://deploy-preview-116--languagemapping.netlify.app/ YT playlists and Archive are all kinds of broken but I'm not stuck, just spent for the night, I should be able to wrap it up tomorrow though. |
Internet Archive audio files can be used in a web player inside an <iframe>, so no reason to support <audio> anymore. Especially since the old `wav`-only download URL also works in an iframe (at least in Google Chrome, which was all that was tested). Who knew?
abettermap
force-pushed
the
72.media-meta
branch
from
e9106d0 to
5259294
Compare
- Improve error reporting to Sentry with more descriptive tags, messages, and environments. - Gently let the user know that their video world fell apart via simple UI component. - Use Netlify config env variables to set Sentry environment so that local (Jason) vs. deploy vs. production can be differentiated. Error scenarios covered: 1. Incorrect URL format from the data (needs to be YouTube playlist, embed, or Internet Archive embed) 2. Format was fine but no video/embed/etc. was found 3. General fetch failure catch-all
|
Ross- here's most recent deploy (same url): https://deploy-preview-116--languagemapping.netlify.app/ let me know if i missed anything in here or #72 |
abettermap
force-pushed
the
72.media-meta
branch
from
99ef627 to
8ce2cb3
Compare
- Remove HTML support for descriptions (see comment in code) - Correct playlist URLs (YT vids can't have "playlist" in them") - Remove "(playlist)" from playlist modal titles
|
all good
… On Oct 20, 2020, at 6:06 PM, Jason Lampel ***@***.***> wrote:
@rperlin-ela <https://github.com/rperlin-ela> all good?
https://deploy-preview-116--languagemapping.netlify.app/ <https://deploy-preview-116--languagemapping.netlify.app/>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMNKB5H74MHB3XIQYQAXDHTSLYCUXANCNFSM4SROP44Q>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72