Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Details, maybe fix endo issue? #69

Merged
merged 17 commits into from
Sep 1, 2020
Merged

Finalize Details, maybe fix endo issue? #69

merged 17 commits into from
Sep 1, 2020

Conversation

abettermap
Copy link
Contributor

@abettermap abettermap commented Aug 31, 2020

Details

Pretty up the Details section, including wiring up media:

image

Fonts/endos

I think loading all the fonts and setting the CSS to use them seemed to fix the problem? I confirmed that it's not coming from the image, will explain in comments below

@abettermap abettermap changed the title WIP: finalize Details Finalize Details, maybe fix endo issue? Sep 1, 2020
@abettermap
Copy link
Contributor Author

@rperlin-ela

I may have gotten the fonts to work w/o images but it's late and needs more testing.

I pushed up one more commit for you to test on:

  1. in your dataset, change one of the problematic fonts (Sylheti maybe?) to have nothing in the Font Image Alt column
  2. upload to mb
  3. go to deploy url: https://deploy-preview-69--languagemapping.netlify.app/
  4. does the font show in Details??? you can confirm it's not an image by highlighting a character:

image

if so then i think it's working w/o image.

Wowww if that's the case! I 100% did not expect it to work like this.

If it IS working then I'll adjust to make ASL/mongolian work again along w/showing the native endo in popup, tooltips, table, etc.

if it's working and we've confirmed it then... really sorry you had to go through 1 million steps!

if it's not then... thanks for uploading all those SVGs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant