Handle dynamic model relations #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
[ci skip] [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
Fixes #5635
BEFORE - What was wrong? What was happening before this PR?
We were not identifying dynamic relations on models.
Developers could do
Model::resolveRelationUsing('something', fn($item) => $item->belongsTo())and expect thatCRUD::field('something')would work as if they were defining any other relationship field for relations that are explicitly defined on the modelpublic function something() { return $this->belongsTo(); }AFTER - What is happening after this PR?
We can properly identify dynamic relations on models. 🥳
HOW
How did you achieve that, in technical terms?
Changed the relevant functions that identify and work with relations to account for the fact that there might be dynamic relationships defined .
Is it a breaking change?
I don't think so, no. Tests are green, added more tests to account for this.
How can we test the before & after?
Define a dynamic relation on your model, and then try
CRUD::field('relationName')and it won't work before this PR.