Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix php82 deprecation warning #68

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix php82 deprecation warning #68

merged 2 commits into from
Sep 26, 2023

Conversation

makss
Copy link
Contributor

@makss makss commented Sep 26, 2023

PHP 8.2 generate deprecation warnings:

Creation of dynamic property Backpack\LogManager\app\Http\Controllers\LogController::$data is deprecated in /vendor/backpack/logmanager/src/app/Http/Controllers/LogController.php on line 17 
Creation of dynamic property Backpack\LogManager\app\Http\Controllers\LogController::$data is deprecated in /vendor/backpack/logmanager/src/app/Http/Controllers/LogController.php on line 38

Defining $data solves this problem.

@tabacitu tabacitu merged commit e1e3b32 into Laravel-Backpack:main Sep 26, 2023
2 of 3 checks passed
@tabacitu
Copy link
Member

Awesome, thank you @makss . Merged & tagged. Keep 'em coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makss @tabacitu