added inline validation strings for en, de and de-CH #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, thank you. Yes, it's the better idea in same branch ;) I try to review this week, and I have to update the todo.php |
caouecs
requested changes
Jul 8, 2020
src/en/validation-inline.php
Outdated
| 'string' => 'This string must be between :min and :max characters.', | ||
| 'array' => 'This content must have between :min and :max items.', | ||
| ], | ||
| 'boolean' => 'This field field must be true or false.', |
src/en/validation-inline.php
Outdated
| 'ends_with' => 'This must end with one of the following: :values.', | ||
| 'exists' => 'The selected value is invalid.', | ||
| 'file' => 'The content must be a file.', | ||
| 'filled' => 'This field field must have a value.', |
src/en/validation-inline.php
Outdated
| 'numeric' => 'The value must be greater than or equal :value.', | ||
| 'file' => 'The file size must be greater than or equal :value kilobytes.', | ||
| 'string' => 'The string must be greater than or equal :value characters.', | ||
| 'array' => 'The Content must have :value items or more.', |
src/en/validation-inline.php
Outdated
| 'required_with_all' => 'This field is required when :values are present.', | ||
| 'required_without' => 'This field is required when :values is not present.', | ||
| 'required_without_all' => 'This field is required when none of :values are present.', | ||
| 'same' => 'The Value of this field must match the one from :other.', |
src/de-CH/validation-inline.php
Outdated
| 'numeric' => 'Der Wert muss kleiner :value sein.', | ||
| 'file' => 'Die Datei muss kleiner :value Kilobytes gross sein.', | ||
| 'string' => 'Die Zeichenkette muss kleiner :value Zeichen lang sein.', | ||
| 'array' => ':Der Inhalt muss kleiner :value Elemente haben.', |
src/de/validation-inline.php
Outdated
| 'numeric' => 'Der Wert muss kleiner als :value sein.', | ||
| 'file' => 'Die Datei muss kleiner als :value Kilobytes sein.', | ||
| 'string' => 'Die Zeichenkette muss kürzer als :value Zeichen sein.', | ||
| 'array' => ':Der Inhalt muss weniger als :value Elemente haben.', |
2 tasks
|
Thank you |
Big thanks for the intensive review and the fixes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1268
As discussed the translated strings for en, de (and de-CH).
@caouecs I made separate, non overlapping files for this. I think, maintaining them in a different branch might not be optimal. However, I'm open for other inputs where to put and how to name the files.