Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Do not create output file until at least one chunk was received #140

Open
fireattack opened this issue Nov 22, 2024 · 1 comment

Comments

@fireattack
Copy link
Contributor

fireattack commented Nov 22, 2024

Basic Information

  • Node.js version: v20.5.1
  • Minyami version: Minyami / A lovely video downloader / 5.4.0
    うめにゃん~ (虎>ω<)
  • Minyami Extractor (Chrome Extension) version:
  • Video URL:

Describe the bug

Currently if you initiate a task, no matter how early it fails (failed to fetch m3u8, failed to parse, failed to download any chunk, etc.), it will still create a .ts file.

I personally think this is unexpected and minyami should only start creating this file once it started downloading actual chunks.

Same goes to temp folder -- but from my observation, at least if the fetching of m3u8 was failed it will not create temp folder, which is good.

@fireattack fireattack changed the title [Suggestion] Do not create file/temp folder until at least first chunk was received [Suggestion] Do not create output file until at least first chunk was received Nov 22, 2024
@fireattack fireattack changed the title [Suggestion] Do not create output file until at least first chunk was received [Suggestion] Do not create output file until at least one chunk was received Nov 22, 2024
Last-Order added a commit that referenced this issue Nov 24, 2024
@Last-Order
Copy link
Owner

Good suggestion. Should be fixed in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants