Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazilian Portuguese built-in deck and translation update #130

Closed
wants to merge 2 commits into from
Closed

Brazilian Portuguese built-in deck and translation update #130

wants to merge 2 commits into from

Conversation

flipeip
Copy link
Contributor

@flipeip flipeip commented May 4, 2020

Here is the translation to the new strings and the built-in deck (following #127).
Also, I want to note that the deck's name is actually the translation of "Cards Against Humanity" in this language, but I'm not sure if this is the right option.

@Lattyware
Copy link
Owner

Wow, thanks for such a quick PR!

As to the name, that's a good question.

Ideally we'd explicitly note the language and the fact this is a translation rather than a localization (at least, I assume—as far as I can tell it still includes American references and so on, and is a direct translation). For now, I think this is probably fine, and I'll probably take a look at some point at expanding the amount of detail about the decks we present.

@Lattyware
Copy link
Owner

Sorry this took me so long to pull in, but it now is in. Thanks again for the contribution!

@Lattyware Lattyware closed this May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants