House Rule: Happy Ending #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally pushed changes to this deck.
Added a new card source called "Generated" for cards hardcoded into the game such as the Haiku card in the happy ending house rule.
|
Nice work, I'll take a look over and merge it through when I get the chance. Thanks for the contribution. |
|
Merged as of 3625f65, sorry for the delay getting this in, and thanks for the contribution! Nice to see this feature finally in the game. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the "Happy Ending" house rule as outlined in #49.
As part of the new house rule, this PR adds a new card source called "Generated" for cards that are hard-coded for purposes such as house rules.
Translation Issues:
Testing
The happy ending house rule has been successfully tested in a dev environment. (But more testing can't hurt!)