Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp and proofread Spanish language #364

Closed
wants to merge 2 commits into from

Conversation

rafitamolin
Copy link
Contributor

Completely revamped the Spanish localization. List of major changes:

  • The plural function was incorrectly programmed, so many words were displayed grammatically incorrect in the game.
  • Many misspelled words (typos) have been corrected.
  • The words used have been refined to ensure that they are as understandable as possible.
  • A list of Spanish language contributors has been added.

Completely revamped the Spanish localization. List of major changes:

- The plural function was incorrectly programmed, so many words were displayed grammatically incorrect in the game.
- Many misspelled words (typos) have been corrected.
- The words used have been refined to ensure that they are as understandable as possible.
- A list of Spanish language contributors has been added.
Copy link
Contributor

@TheChilliPL TheChilliPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a native speaker, but decided to take a look and point out some things I'm not sure about.
In general, it does fix a lot of things, but I did find some places I needed to comment on.
Feel free to stick with your current translation if you deem my suggestions unnecessary.

Also, I'm not sure about some changes between the past tenses (pretérito and antepresente). The exact usage of these two highly varies between regions, so I think the best thing would be to establish a rule so that it's all consistent in the entirety of this translation.


GameCode { code } ->
[ Text code ]

GameCodeSpecificDescription ->
[ Text "Dale este codigo a gente para que se pueda unir a la partida.." ]
[ Text "Dale este código a la gente para que se puedan unir a la partida." ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't «pueda» still be better? «La gente» is grammatically singular

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have restructured the sentence to make it more correct and simple and thus fix the problem.

[ Text "Comparte este código para que la gente pueda unirse a la partida." ]


Invite ->
[ Text "Invita a jugadores a la sala." ]
[ Text "Invita jugadores a la partida." ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the so-called a personal obligatory in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verb invitar is transitive, there is no need for a prepositional complement.


HouseRuleNeverHaveIEver ->
[ Text "Yo Nunca" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original translation still works with the same joke as the original

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

HouseRuleWinnersPickDescription ->
[ Missing ]
[ Text "El ganador de cada ronda será el ", ref Czar, Text " durante la próxima ronda." ]

SeeAlso { rule } ->
[ Text "Ver también: ", ref rule ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the classical «Véase también»?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.


NotificationsOnlyWhenHiddenUnsupportedExplanation ->
[ Text "Tu navegador no puede comprobar la visivilidad de la página." ]
[ Text "Tu navegador soporta comprobar la visibilidad de la página." ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is shown when the browser doesn't support checking the page visibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.


Left ->
[ Text "Se ha ido" ]
[ Text "Se fueron" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but that may be shown for a single user (worth checking in the original translation), so «Se ha ido» or «Se fue» would work

Copy link
Contributor Author

@rafitamolin rafitamolin May 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but I have translated it this way because it makes more sense to think of the translation as "Lista de usuarios que [Se fueron]", and even if it's one person, it makes sense.

The other way, if you speak in singular and there is a long list of users who have left, it makes less sense.

Copy link
Contributor Author

@rafitamolin rafitamolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected the issues shared by @TheChilliPL.

The current version of the translation is correct for release, further improvements can be made in the future, but this version needs to be released as soon as possible to fix many issues in the initial version of the translation.

Please @Lattyware have a look at it when you can. Thanks!

@Lattyware
Copy link
Owner

I'll take a look at merging this as soon as I get a chance. We are just about to launch a game, so it'll probably be a few days but I'll get to it ASAP.

@Lattyware
Copy link
Owner

Merged as 08a61e6 and released in 2.8.0. Thanks for the contribution.

@Lattyware Lattyware closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants