Chore: Support Webpack 5 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chawes13
commented
Mar 9, 2023
| } | ||
|
|
||
| webpack(config, (err, stats) => { | ||
| expect(err).toEqual(null) | ||
| const modules = stats.toJson().modules | ||
| const modules = stats.toJson({ source: true }).modules |
There was a problem hiding this comment.
chawes13
commented
Mar 9, 2023
| expect(modules.length).toEqual(4) | ||
| const indexFileContent = modules.pop().source | ||
| const indexFileContent = modules.find((module) => module.name.includes('.index.js')).source |
There was a problem hiding this comment.
Webpack 5 returns the .index file as the first file. Instead of switching this to .shift, I thought it would be more future proof to actually find the file.
chawes13
commented
Mar 9, 2023
| const config = { | ||
| mode: 'production', |
There was a problem hiding this comment.
Webpack recommends always adding mode
mwislek
approved these changes
Mar 10, 2023
|
I've pulled it into a client project with webpack 5 and you're using it on another project with that same setup, so I'd say it works! The tests passed for me locally so let me look at why Travis is complaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14